Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATE-2661: Fixes issue with rule precedence updates by using a genera… #1663

Conversation

norwoodj
Copy link

@norwoodj norwoodj commented Jun 1, 2022

…ted version of precendence in API calls to reduce clashing versions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@norwoodj norwoodj force-pushed the jnorwood/GATE-2661/rule-precedence-fix branch from 08987e9 to 310c628 Compare June 1, 2022 15:36
…ted version of precendence in API calls to reduce clashing versions
@norwoodj norwoodj force-pushed the jnorwood/GATE-2661/rule-precedence-fix branch from 310c628 to f597b7e Compare June 2, 2022 09:40
@jacobbednarz
Copy link
Member

acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTeamsRuleBasic" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTeamsRuleBasic
--- PASS: TestAccCloudflareTeamsRuleBasic (13.62s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	14.111s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit 485630a into cloudflare:master Jun 8, 2022
@jacobbednarz
Copy link
Member

thanks a bunch for this @norwoodj 🥇

@github-actions github-actions bot added this to the v3.17.0 milestone Jun 8, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants