Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_access_group: reference ip list in include statement #1665

Closed
fwwieffering opened this issue Jun 2, 2022 · 2 comments · Fixed by #2073
Closed

cloudflare_access_group: reference ip list in include statement #1665

fwwieffering opened this issue Jun 2, 2022 · 2 comments · Fixed by #2073
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/access Categorizes issue or PR as related to the Access service. workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Milestone

Comments

@fwwieffering
Copy link

Current Terraform and Cloudflare provider version

v3.16.0

Description

cloudflare_teams_list now supports IP type #1550 but it isn't possible to reference IP lists. the best I can do is reference the items attribute.

In the UI there is an option to add include rules for IP List
image

Use cases

Pass a list of items by reference instead of by value

Potential Terraform configuration

resource "cloudflare_teams_list" "ip_allowlist" {
  account_id = var.account_id
  name       = "ip allowlist"
  type       = "IP"
  items = [
    "1.2.3.4"
  ]
}

resource "cloudflare_access_group" "ip_group" {
  account_id     = var.account_id
  name           = "staging group"

  include {
    ip_list = resource.cloudflare_teams_list.ip_allowlist.id
  }
}

References

No response

@fwwieffering fwwieffering added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 2, 2022
@jacobbednarz jacobbednarz added workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. service/access Categorizes issue or PR as related to the Access service. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 2, 2022
@keitap
Copy link
Contributor

keitap commented Dec 3, 2022

I needed this feature too, so I implemented it and am waiting for a review.

@github-actions github-actions bot added this to the v3.33.0 milestone Jan 18, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v3.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/access Categorizes issue or PR as related to the Access service. workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
3 participants