Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for cloudflare_logpush_job kind attribute #1718

Merged
merged 3 commits into from Jun 28, 2022

Conversation

sbfaulkner
Copy link
Contributor

@sbfaulkner sbfaulkner commented Jun 21, 2022

depends on cloudflare/cloudflare-go#936 - which is awaiting public api (documentation)

adds the kind attribute to the cloudflare_logpush_job resource

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

changelog detected ✅

go.mod Outdated Show resolved Hide resolved
.changelog/1718.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

once you address these couple of things, you'll need to run make docs to generate the updated documentation too.

sbfaulkner and others added 2 commits June 28, 2022 18:59
@sbfaulkner
Copy link
Contributor Author

@jacobbednarz not sure what I'm missing, but I can't get make docs to run - maybe an issue with running things on an M1?

$ make docs
==> Installing development tooling...
go generate -tags tools tools/tools.go
rendering website for provider "terraform-provider-cloudflare" (as "Cloudflare")
copying any existing content to tmp dir
exporting schema from Terraform
compiling provider "cloudflare"
using Terraform CLI binary from PATH if available, otherwise downloading latest Terraform CLI binary
running terraform init
Error executing command: unable to generate website: exit status 1

Error: Incompatible provider version

Provider registry.terraform.io/hashicorp/cloudflare v0.0.1 does not have a
package available for your current platform, darwin_amd64.

Provider releases are separate from Terraform CLI releases, so not all
providers are available for all platforms. Other versions of this provider
may have different platforms supported.

@jacobbednarz
Copy link
Member

tbh, i haven't tried it on a M1. i'll merge this as is and regenerate. will look into that later, thanks.

@jacobbednarz jacobbednarz merged commit de0ffb3 into cloudflare:master Jun 28, 2022
@github-actions github-actions bot added this to the v3.18.0 milestone Jun 28, 2022
github-actions bot pushed a commit that referenced this pull request Jun 28, 2022
@sbfaulkner
Copy link
Contributor Author

@jacobbednarz I figured it out... I had to update tfenv and reinstall terraform to get the M1 binaries and then make docs worked. Thanks for dealing with it for me

@jacobbednarz
Copy link
Member

awesome! great to know it's already handled. will regenerate the docs shortly.

@github-actions
Copy link
Contributor

This functionality has been released in v3.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants