Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add queueing_method to cloudflare_waiting_room #1759

Merged

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Jul 7, 2022

Add a queueing_method property to cloudflare_waiting_room resource.

This is already publicly documented. https://api.cloudflare.com/#waiting-room-create-waiting-room

@broswen broswen force-pushed the add-waitingroom-queueing-method branch from c9569dd to b578250 Compare July 7, 2022 04:15
@broswen broswen changed the title add waiting_room queueing_method add queueing_method to cloudflare_waiting_room Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests are good

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareWaitingRoom_" -count 1 -parallel 1 -timeout 120m -parallel 1

=== RUN   TestAccCloudflareWaitingRoom_Create
=== PAUSE TestAccCloudflareWaitingRoom_Create
=== CONT  TestAccCloudflareWaitingRoom_Create
--- PASS: TestAccCloudflareWaitingRoom_Create (8.88s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   9.661s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

@jacobbednarz jacobbednarz merged commit 28083eb into cloudflare:master Jul 7, 2022
@github-actions github-actions bot added this to the v3.19.0 milestone Jul 7, 2022
github-actions bot pushed a commit that referenced this pull request Jul 7, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.19.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants