Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_custom_ssl: handle when updates remote ID #1824

Merged
merged 1 commit into from Aug 8, 2022

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Aug 8, 2022

Supersedes/closes #1025
Closes #1806

@jacobbednarz
Copy link
Member Author

acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareCustomSSL_" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareCustomSSL_Basic
--- PASS: TestAccCloudflareCustomSSL_Basic (10.12s)
=== RUN   TestAccCloudflareCustomSSL_WithEmptyGeoRestrictions
--- PASS: TestAccCloudflareCustomSSL_WithEmptyGeoRestrictions (11.67s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   22.353s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 85de2df into master Aug 8, 2022
@jacobbednarz jacobbednarz deleted the update-of-1025 branch August 8, 2022 05:01
@github-actions github-actions bot added this to the v3.21.0 milestone Aug 8, 2022
github-actions bot pushed a commit that referenced this pull request Aug 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

This functionality has been released in v3.21.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The patch of custom_certificates does not detect id change
1 participant