Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for email routing #1856

Merged
merged 14 commits into from Aug 31, 2022
Merged

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Aug 25, 2022

Resolves #1460

Adds terraform support for Email Routing.

@github-actions
Copy link
Contributor

changelog detected ✅

@Cyb3r-Jak3
Copy link
Contributor Author

Tests pass when using cloudflare/cloudflare-go#1070

$ TESTARGS='-run "TestAccTestEmailRouting" -count 1 -parallel 1' make testacc
TF_ACC=1 go test $(go list ./...) -v -run "TestAccTestEmailRouting" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccTestEmailRoutingAddress
--- PASS: TestAccTestEmailRoutingAddress (2.98s)
=== RUN   TestAccTestEmailRoutingCatchAll
--- PASS: TestAccTestEmailRoutingCatchAll (2.23s)
=== RUN   TestAccTestEmailRoutingRule
--- PASS: TestAccTestEmailRoutingRule (2.19s)
=== RUN   TestAccTestEmailRoutingSettings
--- PASS: TestAccTestEmailRoutingSettings (2.20s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   9.610s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as ready for review August 30, 2022 01:59
@gitguardian
Copy link

gitguardian bot commented Aug 31, 2022

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 421cb7b examples/resources/cloudflare_pages_project/resource.tf View secret
- Generic High Entropy Secret 421cb7b internal/provider/resource_cloudflare_pages_project_test.go View secret
- Generic High Entropy Secret 421cb7b internal/provider/resource_cloudflare_pages_project_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@jacobbednarz jacobbednarz merged commit 53a4333 into cloudflare:master Aug 31, 2022
@github-actions github-actions bot added this to the v3.23.0 milestone Aug 31, 2022
github-actions bot pushed a commit that referenced this pull request Aug 31, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the email-routing branch September 3, 2022 22:16
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This functionality has been released in v3.23.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email routing configuration support
2 participants