fix retrieval of enabled for cloudflare_authenticated_origin_pulls

[nickysemenza]

// GetOk returns the data for the given key and whether or not the key
// has been set to a non-zero value at some point.

if the tfstate explicitly has enabled = false, then it technically stays at the zero value, which means that the second return value from GetOk (ok) returns false. If hostname is an empty string (such as whencloudflare_authenticated_origin_pulls_certificate has type = "per-zone" (as opposed to per-hostname), then those 2 cancel each other out:

switch false {
  case false:
     // uh oh this evaluates

resource/cloudflare_authenticated_origin_pulls: fix improper handling of enabled=false

Resolves #1832

[github-actions]

changelog detected ✅

[gitguardian]

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	3ba5bd2	examples/resources/cloudflare_pages_project/resource.tf	View secret
-	Generic High Entropy Secret	3ba5bd2	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	3ba5bd2	internal/provider/resource_cloudflare_pages_project_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[nickysemenza]

using the example in the linked issue:

Terraform will perform the following actions:

  # cloudflare_authenticated_origin_pulls.foo will be updated in-place
  ~ resource "cloudflare_authenticated_origin_pulls" "foo" {
      ~ enabled                                = true -> false
        id                                     = "181f5c8ccd67aeb7bd487f4a10a77a14"
        # (2 unchanged attributes hidden)
    }

[github-actions]

This functionality has been released in v3.23.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!