Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare_worker): add missing js module option to fix upload #1865

Merged
merged 7 commits into from Aug 31, 2022

Conversation

js0cha
Copy link
Contributor

@js0cha js0cha commented Aug 26, 2022

Closes #1417

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

changelog detected ✅

@js0cha js0cha force-pushed the fix-cloudflare-worker-upload branch 3 times, most recently from b003edc to 53b2e1d Compare August 26, 2022 16:30
@js0cha js0cha force-pushed the fix-cloudflare-worker-upload branch from 53b2e1d to 942ed14 Compare August 26, 2022 16:51
@jacobbednarz
Copy link
Member

can we please add some acceptance tests to cover this updated behaviour? i'd like to make sure we have the coverage in place for this given it required a few updates to the core request/response lifecycle.

@js0cha js0cha force-pushed the fix-cloudflare-worker-upload branch from d3d1d1d to 07a988c Compare August 29, 2022 11:00
@js0cha js0cha requested review from Electroid and jacobbednarz and removed request for jacobbednarz and Electroid August 30, 2022 07:26
@jacobbednarz
Copy link
Member

i've fixed the docs + added a test for this which is now all passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareWorkerScript_" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareWorkerScript_Import
--- PASS: TestAccCloudflareWorkerScript_Import (12.91s)
=== RUN   TestAccCloudflareWorkerScript_MultiScriptEnt
=== PAUSE TestAccCloudflareWorkerScript_MultiScriptEnt
=== RUN   TestAccCloudflareWorkerScript_ModuleUpload
=== PAUSE TestAccCloudflareWorkerScript_ModuleUpload
=== CONT  TestAccCloudflareWorkerScript_MultiScriptEnt
--- PASS: TestAccCloudflareWorkerScript_MultiScriptEnt (35.64s)
=== CONT  TestAccCloudflareWorkerScript_ModuleUpload
--- PASS: TestAccCloudflareWorkerScript_ModuleUpload (9.73s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   58.849s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

@jacobbednarz jacobbednarz merged commit 3de898e into cloudflare:master Aug 31, 2022
@github-actions github-actions bot added this to the v3.23.0 milestone Aug 31, 2022
@jacobbednarz
Copy link
Member

thanks for this one @js0cha 👏

github-actions bot pushed a commit that referenced this pull request Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This functionality has been released in v3.23.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for cloudflare_worker_script resources being module syntax
3 participants