New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cloudflare_url_normalization_settings resource #1878
Conversation
changelog detected ✅ |
4d89290
to
5341543
Compare
5341543
to
7aca8fa
Compare
We are going to have the DELETE API by the end of this month. Setting PR to draft until that. |
Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the |
Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the |
@tamas-jozsa any update here? |
@sbfaulkner development has been delayed on the API side, and I'm not sure about their ETA. I can close this PR and reopen once we move forward, if that sounds OK for you. |
Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jacobbednarz I think this is good to go now. We had a discussion with the FL team and it looks like setting to the default value (as @tamas-jozsa has done here) is the way they want to handle the DELETE calls. |
I'll re-run the acceptance test suite tomorrow when I'm back near a computer. @tamas-jozsa are you able to mark this as ready when you are good to go? |
acceptance tests all passing
|
This functionality has been released in v3.30.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm marking this PR as draft, as FL Team is still working on the DELETE endpoint. I'll need to update that here once it's completed.
I used https://api.cloudflare.com/#url-normalization-properties to craft this resource.
Even though the API schema marks
type
andscope
params as optional, I confirm that they are required.Closes #2026