Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloudflare_url_normalization_settings resource #1878

Merged
merged 3 commits into from Dec 14, 2022

Conversation

tamas-jozsa
Copy link
Contributor

@tamas-jozsa tamas-jozsa commented Sep 1, 2022

I'm marking this PR as draft, as FL Team is still working on the DELETE endpoint. I'll need to update that here once it's completed.

I used https://api.cloudflare.com/#url-normalization-properties to craft this resource.
Even though the API schema marks type and scope params as optional, I confirm that they are required.

Closes #2026

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

changelog detected ✅

@tamas-jozsa tamas-jozsa force-pushed the tamas/url-normalization-settings branch from 4d89290 to 5341543 Compare September 1, 2022 11:02
@tamas-jozsa tamas-jozsa force-pushed the tamas/url-normalization-settings branch from 5341543 to 7aca8fa Compare September 1, 2022 11:02
@tamas-jozsa tamas-jozsa marked this pull request as draft September 1, 2022 11:06
@tamas-jozsa tamas-jozsa marked this pull request as ready for review September 9, 2022 09:38
@tamas-jozsa tamas-jozsa marked this pull request as draft September 9, 2022 09:39
@tamas-jozsa
Copy link
Contributor Author

We are going to have the DELETE API by the end of this month. Setting PR to draft until that.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@sbfaulkner
Copy link
Contributor

@tamas-jozsa any update here?

@tamas-jozsa
Copy link
Contributor Author

@sbfaulkner development has been delayed on the API side, and I'm not sure about their ETA. I can close this PR and reopen once we move forward, if that sounds OK for you.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@jacobbednarz jacobbednarz added workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team. and removed lifecycle/stale labels Nov 6, 2022
Copy link
Contributor

@jafowler jafowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafowler
Copy link
Contributor

@jacobbednarz I think this is good to go now. We had a discussion with the FL team and it looks like setting to the default value (as @tamas-jozsa has done here) is the way they want to handle the DELETE calls.

@jacobbednarz
Copy link
Member

jacobbednarz commented Dec 13, 2022

I'll re-run the acceptance test suite tomorrow when I'm back near a computer.

@tamas-jozsa are you able to mark this as ready when you are good to go?

@jacobbednarz jacobbednarz marked this pull request as ready for review December 14, 2022 03:57
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareURLNormalizationSettings_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareURLNormalizationSettings_CreateThenUpdate
=== PAUSE TestAccCloudflareURLNormalizationSettings_CreateThenUpdate
=== CONT  TestAccCloudflareURLNormalizationSettings_CreateThenUpdate
--- PASS: TestAccCloudflareURLNormalizationSettings_CreateThenUpdate (24.02s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	24.460s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit cac0f08 into master Dec 14, 2022
@jacobbednarz jacobbednarz deleted the tamas/url-normalization-settings branch December 14, 2022 04:01
@github-actions github-actions bot added this to the v3.30.0 milestone Dec 14, 2022
github-actions bot pushed a commit that referenced this pull request Dec 14, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.30.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: URL normalization
4 participants