Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudflare_user_agent_blocking_rule resource #1894

Merged
merged 8 commits into from Sep 9, 2022

Conversation

tamas-jozsa
Copy link
Contributor

@tamas-jozsa tamas-jozsa commented Sep 7, 2022

Marking as draft, as I need to update cf-go to use common method signatures: https://github.com/cloudflare/cloudflare-go/blob/master/user_agent.go

Adding new User Agent Blocking rules resource: https://api.cloudflare.com/#user-agent-blocking-rules-properties

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

changelog detected ✅

@tamas-jozsa tamas-jozsa changed the title user-agent-blocking-rules: Add new resource Add new resource: user-agent-blocking-rules Sep 7, 2022
@tamas-jozsa tamas-jozsa changed the title Add new resource: user-agent-blocking-rules Add cloudflare_user_agent_blocking_rule resource Sep 7, 2022
@tamas-jozsa tamas-jozsa marked this pull request as draft September 7, 2022 15:00
@jacobbednarz
Copy link
Member

if the methods are already there (and not requiring zone and account level access), it's fine to leave the methods as is for now. we can update them in another pass.

(This is older functionality fwiw so it may end up deprecated for ERE)

@tamas-jozsa tamas-jozsa marked this pull request as ready for review September 8, 2022 08:16
@tamas-jozsa
Copy link
Contributor Author

I followed up with ERE and confirmed, that this will be deprecated. I agree, that we should go with these methods for now and do the update after official deprecation.

Marking PR for ready for review.

@jacobbednarz
Copy link
Member

acceptance tests are all passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareUserAgentBlockingRule" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareUserAgentBlockingRule
--- PASS: TestAccCloudflareUserAgentBlockingRule (8.40s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   9.187s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

thanks!

@jacobbednarz jacobbednarz merged commit 98430ae into master Sep 9, 2022
@jacobbednarz jacobbednarz deleted the user-agent-blocking-rules branch September 9, 2022 04:40
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 9, 2022
github-actions bot pushed a commit that referenced this pull request Sep 9, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.24.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants