Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null source bug with null source for pages project #1898

Merged
merged 1 commit into from Sep 8, 2022

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Sep 7, 2022

Fixes #1897

I forget to set the project source, which caused it to not be created. Unit tests didn't seem to catch it 😬

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests are good, thanks!

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflarePagesProject_" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflarePagesProject_BuildConfig
--- PASS: TestAccCloudflarePagesProject_BuildConfig (10.34s)
=== RUN   TestAccCloudflarePagesProject_DeploymentConfig
--- PASS: TestAccCloudflarePagesProject_DeploymentConfig (9.99s)
=== RUN   TestAccCloudflarePagesProject_DirectUpload
--- PASS: TestAccCloudflarePagesProject_DirectUpload (10.23s)
=== RUN   TestAccCloudflarePagesProject_PreviewOnly
--- PASS: TestAccCloudflarePagesProject_PreviewOnly (10.52s)
=== RUN   TestAccCloudflarePagesProject_ProductionOnly
--- PASS: TestAccCloudflarePagesProject_ProductionOnly (9.69s)
PASS
PASS    github.com/cloudflare/terraform-provider-cloudflare/internal/provider   54.986s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]
PASS

@jacobbednarz jacobbednarz merged commit ddca523 into cloudflare:master Sep 8, 2022
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 8, 2022
github-actions bot pushed a commit that referenced this pull request Sep 8, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the page-project-source branch September 8, 2022 01:02
@github-actions
Copy link
Contributor

This functionality has been released in v3.24.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a GitHub/GitLab Pages project
2 participants