provider: allow configuring x-auth-service-key individually
#1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following in the footsteps of #1768 (comment), this introduces the ability to set the x-auth-service-key individually without setting another authentication mechanism. Prior to 3.18, you could set multiple and the internals looked busted but sometimes worked...and other times didn't. This is hopefully the last case we need to tidy up to correctly set the auth correctly for the request that users are making. Closes #1905
|
changelog detected ✅ |
|
This functionality has been released in v3.24.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
2 tasks
|
@jacobbednarz there may still be an authentication info case that is not covered. I opened #1939 based on what I'm seeing in 3.24.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the footsteps of
#1768 (comment), this introduces the ability to set the x-auth-service-key individually without setting another authentication mechanism. Prior to 3.18, you could set multiple and the internals looked busted but sometimes worked...and other times didn't.
This is hopefully the last case we need to tidy up to correctly set the auth correctly for the request that users are making.
Closes #1905