Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify type = drop for cloudflare_email_routing_catch_all #1937

Closed
2 tasks done
yan12125 opened this issue Sep 29, 2022 · 2 comments · Fixed by #1947
Closed
2 tasks done

Cannot specify type = drop for cloudflare_email_routing_catch_all #1937

yan12125 opened this issue Sep 29, 2022 · 2 comments · Fixed by #1947
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@yan12125
Copy link
Contributor

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

$ ./terraform -v
Terraform v1.3.1
on linux_amd64
+ provider registry.terraform.io/cloudflare/cloudflare v3.24.0

Affected resource(s)

cloudflare_email_routing_catch_all

Terraform configuration files

terraform {
    required_providers {
        cloudflare = {
            source = "cloudflare/cloudflare"
        }
    }
}

provider "cloudflare" {
    api_token = "0123456789012345678901234567890123456789"
}

resource "cloudflare_email_routing_catch_all" "foobar" {
    zone_id = "YYY"
    name = "Catch-all rule"
    enabled = true
    matcher {
        type = "all"
    }
    action {
        type = "drop"
        value = []
    }
}

Link to debug output

https://gist.github.com/yan12125/f683cbbd61c09b8e2544c30cd6acad37

Panic output

No response

Expected output

Catch-all rule for email routing is enabled and configured to drop all mails.

Actual output

The provider does not like type = drop for cloudflare_email_routing_catch_all.

Steps to reproduce

  1. Run terraform plan

Additional factoids

Per https://api.cloudflare.com/#email-routing-routing-rules-update-catch-all-rule, the catch-all rule accepts type = drop, forward or worker.

References

No response

@yan12125 yan12125 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 29, 2022
@jacobbednarz jacobbednarz added kind/enhancement Categorizes issue or PR as related to improving an existing feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 29, 2022
@jacobbednarz
Copy link
Member

moving to enhancement as this is a new option.

feel free to send over a PR if you'd it addressed immediately.

@yan12125
Copy link
Contributor Author

Thanks! It's not urgent. I may have a look recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants