Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logpush support for "access_requests" dataset #2000

Closed
vcajes opened this issue Oct 28, 2022 · 0 comments · Fixed by #2001
Closed

Logpush support for "access_requests" dataset #2000

vcajes opened this issue Oct 28, 2022 · 0 comments · Fixed by #2001
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/logs Categorizes issue or PR as related to the Logging services. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@vcajes
Copy link
Contributor

vcajes commented Oct 28, 2022

Current Terraform and Cloudflare provider version

Terraform v1.3.2
on darwin_arm64

Description

Cloudflare supports logpush of access logs: https://developers.cloudflare.com/logs/reference/log-fields/account/access_requests/

However, there is a validation on terraform that is not allowing the "access_requests" dataset:

│ Error: expected dataset to be one of [firewall_events http_requests spectrum_events nel_reports audit_logs gateway_dns gateway_http gateway_network dns_logs network_analytics_logs], got access_requests
│ 
│   with cloudflare_logpush_job.access,
│   on main.tf line 50, in resource "cloudflare_logpush_job" "access":
│   50:   dataset          = "access_requests"

Use cases

Same as the other logpush datasets already supported: https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/logpush_job

But in this case for access logs

Potential Terraform configuration

dataset  = "access_requests"

References

No response

@vcajes vcajes added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 28, 2022
@jacobbednarz jacobbednarz added triage/accepted Indicates an issue or PR is ready to be actively worked on. service/logs Categorizes issue or PR as related to the Logging services. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/logs Categorizes issue or PR as related to the Logging services. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
2 participants