Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep order of edge IPs to be same #2032

Merged
merged 4 commits into from Nov 18, 2022

Conversation

gimlid
Copy link
Contributor

@gimlid gimlid commented Nov 17, 2022

When interacting with a Spectrum app that is uses static edge IPs, these changes will ensure the order returned to a user will be consistent.

Closes #1610

When interacting with a Spectrum app that is uses static edge IPs, these
changes will ensure the order returned to a user will be consistent.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 49622ef into cloudflare:master Nov 18, 2022
@jacobbednarz
Copy link
Member

acceptance tests look good

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareSpectrumApplication_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareSpectrumApplication_Import
=== PAUSE TestAccCloudflareSpectrumApplication_Import
=== RUN   TestAccCloudflareSpectrumApplication_Basic
--- PASS: TestAccCloudflareSpectrumApplication_Basic (12.84s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginDNS
--- PASS: TestAccCloudflareSpectrumApplication_OriginDNS (13.26s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginPortRange
--- PASS: TestAccCloudflareSpectrumApplication_OriginPortRange (13.73s)
=== RUN   TestAccCloudflareSpectrumApplication_Update
--- PASS: TestAccCloudflareSpectrumApplication_Update (20.27s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPConnectivity
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPConnectivity (13.18s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPsWithoutConnectivity
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPsWithoutConnectivity (11.35s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPsMultiple
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPsMultiple (20.10s)
=== CONT  TestAccCloudflareSpectrumApplication_Import
--- PASS: TestAccCloudflareSpectrumApplication_Import (14.83s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	120.088s

@github-actions github-actions bot added this to the v3.29.0 milestone Nov 18, 2022
github-actions bot pushed a commit that referenced this pull request Nov 18, 2022
@jacobbednarz
Copy link
Member

thanks @gimlid, you rock!

@github-actions
Copy link
Contributor

This functionality has been released in v3.29.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: The terraform-provider-cloudflare_v3.14.0 plugin crashed!
2 participants