Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tunnel_config #2041

Merged
merged 21 commits into from Nov 25, 2022

Conversation

Cyb3r-Jak3
Copy link
Contributor

Adds support for tunnel configuration
Resolves #1756

Opening as a draft PR for early review while I fix ingress_rule not being configured.

@github-actions
Copy link
Contributor

changelog detected ✅

@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as ready for review November 23, 2022 01:53
@Cyb3r-Jak3
Copy link
Contributor Author

The failing check is because I am using 127.0.0.1 as a tunnel ingress rule IP.

@jacobbednarz
Copy link
Member

The failing check is because I am using 127.0.0.1 as a tunnel ingress rule IP.

instead of 127.0.0.1, can we use an internal (10.x/172.x) address instead that won't trigger the semgrep rules? if not, we can add a skip for this single file.

@Cyb3r-Jak3
Copy link
Contributor Author

I've updated all the docs to use internal IPs addresses. The last reference is to the default IP for the proxy_address.

@jacobbednarz
Copy link
Member

acceptance tests are all good

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTunnelConfig_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTunnelConfig_Full
--- PASS: TestAccCloudflareTunnelConfig_Full (15.76s)
=== RUN   TestAccCloudflareTunnelConfig_Short
--- PASS: TestAccCloudflareTunnelConfig_Short (16.80s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	32.919s

@jacobbednarz jacobbednarz merged commit 2fdb935 into cloudflare:master Nov 25, 2022
@jacobbednarz
Copy link
Member

nice one @Cyb3r-Jak3 🏆

@github-actions github-actions bot added this to the v3.29.0 milestone Nov 25, 2022
github-actions bot pushed a commit that referenced this pull request Nov 25, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the cloudflare_tunnel_config branch November 25, 2022 03:53
@github-actions
Copy link
Contributor

This functionality has been released in v3.29.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@cloudflare cloudflare deleted a comment Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: cloudflare_tunnel_config resource
2 participants