Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gateway egress rule settings #2159

Merged
merged 5 commits into from
Jan 18, 2023

Conversation

Michael9127
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

i think we've done the invert of #2146 here by adding the schema but not the functionality in the CRUD operations 😂 by the looks, you'll need to add these new fields to the respective bits of resource_cloudflare_teams_rules.go

@Michael9127 Michael9127 changed the title Adds missing gateway rule settings Adds gateway egress rule settings Jan 17, 2023
@jacobbednarz
Copy link
Member

i went ahead and extended an integration test here to confirm we were doing all the right things and we're passing on the acceptance tests

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTeamsRuleBasic" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTeamsRuleBasic
--- PASS: TestAccCloudflareTeamsRuleBasic (11.69s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	12.196s

@jacobbednarz jacobbednarz merged commit ef84ef8 into cloudflare:master Jan 18, 2023
@jacobbednarz
Copy link
Member

thanks @Michael9127 🏆

@github-actions github-actions bot added this to the v3.33.0 milestone Jan 18, 2023
github-actions bot pushed a commit that referenced this pull request Jan 18, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v3.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants