Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_record: always send tags object #2205

Merged
merged 3 commits into from Feb 16, 2023

Conversation

jacobbednarz
Copy link
Member

Updates the Update method to always send the tags object to the API which allows clearing of the tags.

Depends on cloudflare/cloudflare-go#1196

Closes #2189

Updates the `Update` method to always send the `tags` object to the API
which allows clearing of the tags.

Closes #2189
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

changelog detected ✅

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@jacobbednarz
Copy link
Member Author

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareRecord_" -timeout 120m
=== RUN   TestAccCloudflareRecord_ImportBasic
--- PASS: TestAccCloudflareRecord_ImportBasic (12.30s)
=== RUN   TestAccCloudflareRecord_ImportSRV
--- PASS: TestAccCloudflareRecord_ImportSRV (12.31s)
=== RUN   TestAccCloudflareRecord_Basic
=== PAUSE TestAccCloudflareRecord_Basic
=== RUN   TestAccCloudflareRecord_CaseInsensitive
=== PAUSE TestAccCloudflareRecord_CaseInsensitive
=== RUN   TestAccCloudflareRecord_Apex
=== PAUSE TestAccCloudflareRecord_Apex
=== RUN   TestAccCloudflareRecord_LOC
=== PAUSE TestAccCloudflareRecord_LOC
=== RUN   TestAccCloudflareRecord_SRV
=== PAUSE TestAccCloudflareRecord_SRV
=== RUN   TestAccCloudflareRecord_CAA
=== PAUSE TestAccCloudflareRecord_CAA
=== RUN   TestAccCloudflareRecord_Proxied
=== PAUSE TestAccCloudflareRecord_Proxied
=== RUN   TestAccCloudflareRecord_Updated
=== PAUSE TestAccCloudflareRecord_Updated
=== RUN   TestAccCloudflareRecord_typeForceNewRecord
=== PAUSE TestAccCloudflareRecord_typeForceNewRecord
=== RUN   TestAccCloudflareRecord_hostnameForceNewRecord
=== PAUSE TestAccCloudflareRecord_hostnameForceNewRecord
=== RUN   TestAccCloudflareRecord_CreateAfterManualDestroy
=== PAUSE TestAccCloudflareRecord_CreateAfterManualDestroy
=== RUN   TestAccCloudflareRecord_TtlValidation
=== PAUSE TestAccCloudflareRecord_TtlValidation
=== RUN   TestAccCloudflareRecord_ExplicitProxiedFalse
=== PAUSE TestAccCloudflareRecord_ExplicitProxiedFalse
=== RUN   TestAccCloudflareRecord_MXWithPriorityZero
=== PAUSE TestAccCloudflareRecord_MXWithPriorityZero
=== RUN   TestAccCloudflareRecord_TtlValidationUpdate
=== PAUSE TestAccCloudflareRecord_TtlValidationUpdate
=== RUN   TestAccCloudflareRecord_HTTPS
=== PAUSE TestAccCloudflareRecord_HTTPS
=== RUN   TestAccCloudflareRecord_MXNull
=== PAUSE TestAccCloudflareRecord_MXNull
=== RUN   TestAccCloudflareRecord_ClearTags
=== PAUSE TestAccCloudflareRecord_ClearTags
=== CONT  TestAccCloudflareRecord_Basic
=== CONT  TestAccCloudflareRecord_hostnameForceNewRecord
=== CONT  TestAccCloudflareRecord_HTTPS
=== CONT  TestAccCloudflareRecord_TtlValidationUpdate
=== CONT  TestAccCloudflareRecord_CAA
=== CONT  TestAccCloudflareRecord_ClearTags
=== CONT  TestAccCloudflareRecord_MXNull
=== CONT  TestAccCloudflareRecord_Updated
--- PASS: TestAccCloudflareRecord_HTTPS (15.35s)
=== CONT  TestAccCloudflareRecord_typeForceNewRecord
--- PASS: TestAccCloudflareRecord_MXNull (15.64s)
=== CONT  TestAccCloudflareRecord_LOC
--- PASS: TestAccCloudflareRecord_Basic (16.72s)
=== CONT  TestAccCloudflareRecord_SRV
--- PASS: TestAccCloudflareRecord_ClearTags (25.49s)
=== CONT  TestAccCloudflareRecord_Apex
--- PASS: TestAccCloudflareRecord_TtlValidationUpdate (25.98s)
=== CONT  TestAccCloudflareRecord_Proxied
--- PASS: TestAccCloudflareRecord_Updated (33.20s)
=== CONT  TestAccCloudflareRecord_CaseInsensitive
--- PASS: TestAccCloudflareRecord_SRV (16.74s)
=== CONT  TestAccCloudflareRecord_TtlValidation
--- PASS: TestAccCloudflareRecord_CAA (34.68s)
=== CONT  TestAccCloudflareRecord_MXWithPriorityZero
--- PASS: TestAccCloudflareRecord_LOC (19.34s)
=== CONT  TestAccCloudflareRecord_ExplicitProxiedFalse
--- PASS: TestAccCloudflareRecord_hostnameForceNewRecord (36.28s)
=== CONT  TestAccCloudflareRecord_CreateAfterManualDestroy
--- PASS: TestAccCloudflareRecord_TtlValidation (8.47s)
--- PASS: TestAccCloudflareRecord_Apex (17.66s)
--- PASS: TestAccCloudflareRecord_Proxied (17.98s)
--- PASS: TestAccCloudflareRecord_typeForceNewRecord (35.50s)
--- PASS: TestAccCloudflareRecord_MXWithPriorityZero (19.22s)
--- PASS: TestAccCloudflareRecord_CaseInsensitive (25.08s)
--- PASS: TestAccCloudflareRecord_CreateAfterManualDestroy (28.50s)
--- PASS: TestAccCloudflareRecord_ExplicitProxiedFalse (34.44s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	94.339s

@jacobbednarz jacobbednarz merged commit 843ec3c into master Feb 16, 2023
@jacobbednarz jacobbednarz deleted the allow-removal-of-dns-tags branch February 16, 2023 03:41
@github-actions github-actions bot added this to the v3.35.0 milestone Feb 16, 2023
github-actions bot pushed a commit that referenced this pull request Feb 16, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v3.35.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can not delete tags
1 participant