Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Page Rules acceptance tests #2213

Merged
merged 2 commits into from Feb 3, 2023
Merged

Conversation

tamas-jozsa
Copy link
Contributor

  • make sure test function names match TestAccCloudflarePageRule_<test_case>
  • fix test resources for failing acceptance tests

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

perfecto! thanks!

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflarePageRule_" -count 1 -parallel 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflarePageRule_Import
=== PAUSE TestAccCloudflarePageRule_Import
=== RUN   TestAccCloudflarePageRule_ImportWithBrowserCacheTTL30
--- PASS: TestAccCloudflarePageRule_ImportWithBrowserCacheTTL30 (12.72s)
=== RUN   TestAccCloudflarePageRule_ImportWithoutBrowserCacheTTL
--- PASS: TestAccCloudflarePageRule_ImportWithoutBrowserCacheTTL (12.01s)
=== RUN   TestAccCloudflarePageRule_Basic
--- PASS: TestAccCloudflarePageRule_Basic (9.88s)
=== RUN   TestAccCloudflarePageRule_FullySpecified
--- PASS: TestAccCloudflarePageRule_FullySpecified (9.93s)
=== RUN   TestAccCloudflarePageRule_ForwardingOnly
--- PASS: TestAccCloudflarePageRule_ForwardingOnly (9.71s)
=== RUN   TestAccCloudflarePageRule_ForwardingAndOthers
--- PASS: TestAccCloudflarePageRule_ForwardingAndOthers (3.91s)
=== RUN   TestAccCloudflarePageRule_DisableZaraz
--- PASS: TestAccCloudflarePageRule_DisableZaraz (9.26s)
=== RUN   TestAccCloudflarePageRule_Updated
--- PASS: TestAccCloudflarePageRule_Updated (16.34s)
=== RUN   TestAccCloudflarePageRule_CreateAfterManualDestroy
--- PASS: TestAccCloudflarePageRule_CreateAfterManualDestroy (16.36s)
=== RUN   TestAccCloudflarePageRule_UpdatingZoneForcesNewResource
--- PASS: TestAccCloudflarePageRule_UpdatingZoneForcesNewResource (16.60s)
=== RUN   TestAccCloudflarePageRule_MinifyAction
--- PASS: TestAccCloudflarePageRule_MinifyAction (9.14s)
=== RUN   TestAccCloudflarePageRule_CreatesBrowserCacheTTLIntegerValues
--- PASS: TestAccCloudflarePageRule_CreatesBrowserCacheTTLIntegerValues (9.33s)
=== RUN   TestAccCloudflarePageRule_CreatesBrowserCacheTTLThatRespectsExistingHeaders
--- PASS: TestAccCloudflarePageRule_CreatesBrowserCacheTTLThatRespectsExistingHeaders (8.97s)
=== RUN   TestAccCloudflarePageRule_UpdatesBrowserCacheTTLToSameValue
--- PASS: TestAccCloudflarePageRule_UpdatesBrowserCacheTTLToSameValue (16.08s)
=== RUN   TestAccCloudflarePageRule_UpdatesBrowserCacheTTLThatRespectsExistingHeaders
--- PASS: TestAccCloudflarePageRule_UpdatesBrowserCacheTTLThatRespectsExistingHeaders (15.75s)
=== RUN   TestAccCloudflarePageRule_DeletesBrowserCacheTTLThatRespectsExistingHeaders
--- PASS: TestAccCloudflarePageRule_DeletesBrowserCacheTTLThatRespectsExistingHeaders (16.25s)
=== RUN   TestAccCloudflarePageRule_EdgeCacheTTLNotClobbered
--- PASS: TestAccCloudflarePageRule_EdgeCacheTTLNotClobbered (15.67s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsBasic
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsBasic (8.87s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsIgnoreQueryStringOrdering
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsIgnoreQueryStringOrdering (8.94s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsExcludeAllQueryString
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsExcludeAllQueryString (8.99s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsExcludeMultipleValuesQueryString
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsExcludeMultipleValuesQueryString (9.03s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsNoQueryStringValuesDefined
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsNoQueryStringValuesDefined (8.89s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsIncludeAllQueryStringValues
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsIncludeAllQueryStringValues (8.86s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsIncludeMultipleValuesQueryString
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsIncludeMultipleValuesQueryString (8.99s)
=== RUN   TestAccCloudflarePageRule_EmptyCookie
--- PASS: TestAccCloudflarePageRule_EmptyCookie (10.05s)
=== RUN   TestAccCloudflarePageRule_CacheTTLByStatus
--- PASS: TestAccCloudflarePageRule_CacheTTLByStatus (9.24s)
=== CONT  TestAccCloudflarePageRule_Import
--- PASS: TestAccCloudflarePageRule_Import (12.26s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	302.510s

@jacobbednarz jacobbednarz merged commit e2e9af4 into master Feb 3, 2023
@jacobbednarz jacobbednarz deleted the page-rule-cookie-empty-array branch February 3, 2023 01:21
@github-actions github-actions bot added this to the v3.34.0 milestone Feb 3, 2023
github-actions bot pushed a commit that referenced this pull request Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This functionality has been released in v3.34.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants