Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update available notification names #2215

Merged
merged 2 commits into from Feb 3, 2023
Merged

Update available notification names #2215

merged 2 commits into from Feb 3, 2023

Conversation

jasoncabot
Copy link
Contributor

@jasoncabot jasoncabot commented Feb 2, 2023

This removes:

  • block_notification_review_accepted
  • g6_health_alert
  • g6_pool_toggle_alert
  • scriptmonitor_alert_new_max_length_script_url
  • scriptmonitor_alert_new_scripts
  • workers_uptime

And adds:

  • block_notification_block_removed
  • fbm_dosd_attack
  • scriptmonitor_alert_new_max_length_resource_url
  • scriptmonitor_alert_new_resources
  • tunnel_health_event
  • tunnel_update_event

Removed notifications are now renamed as follows:

  • g6_health_alert => load_balancing_health_alert
  • g6_pool_toggle_alert => load_balancing_pool_enablement_alert
  • scriptmonitor_alert_new_max_length_script_url => scriptmonitor_alert_new_max_length_resource_url
  • scriptmonitor_alert_new_scripts => scriptmonitor_alert_new_resources

And the following are no longer available:

  • block_notification_review_accepted
  • workers_uptime

Fixes #2117

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

changelog detected ✅

This removes:
* block_notification_review_accepted
* g6_health_alert
* g6_pool_toggle_alert
* scriptmonitor_alert_new_max_length_script_url
* scriptmonitor_alert_new_scripts
* workers_uptime

And adds:
* block_notification_block_removed
* fbm_dosd_attack
* scriptmonitor_alert_new_max_length_resource_url
* scriptmonitor_alert_new_resources
* tunnel_health_event
* tunnel_update_event

Removed notifications are now renamed as follows:

* g6_health_alert => load_balancing_health_alert
* g6_pool_toggle_alert => load_balancing_pool_enablement_alert
* scriptmonitor_alert_new_max_length_script_url => scriptmonitor_alert_new_max_length_resource_url
* scriptmonitor_alert_new_scripts => scriptmonitor_alert_new_resources

And the following are no longer available:
* block_notification_review_accepted
* workers_uptime
@jacobbednarz
Copy link
Member

acceptance tests are all good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareNotificationPolicy_" -count 1 -parallel 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareNotificationPolicy_Basic
--- PASS: TestAccCloudflareNotificationPolicy_Basic (23.47s)
=== RUN   TestAccCloudflareNotificationPolicy_WithFiltersAttribute
--- PASS: TestAccCloudflareNotificationPolicy_WithFiltersAttribute (20.03s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	43.851s

@jacobbednarz jacobbednarz merged commit d6f6344 into cloudflare:master Feb 3, 2023
@github-actions github-actions bot added this to the v3.34.0 milestone Feb 3, 2023
github-actions bot pushed a commit that referenced this pull request Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This functionality has been released in v3.34.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid alert type - scriptmonitor_alert_new_max_length_script_url
2 participants