Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ingress_rule description of cloudflare_tunnel_config #3327

Merged

Conversation

josip-stanic
Copy link
Contributor

Update ingress_rule description of cloudflare_tunnel_config in schema to highlight that last rule must be all matching (unsure whether this well render well the provider docs but it should be mentioned). We came across this as well in our module: https://github.com/avaloqcloud/terraform-cloudflare-service-publishing/blob/main/variables.tf#L278.

workflow/skip-changelog-entry label should be added.

fixes #2920

…highlight that last rule must be all matching.
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included and you have permission, please add the workflow/skip-changelog-entry label. Otherwise, a maintainer will add the label or ask you for one when they review the PR.

@jacobbednarz jacobbednarz added the workflow/skip-changelog-entry Denotes an issue or PR does not require a changelog entry to be added before merging. label May 27, 2024
@jacobbednarz jacobbednarz merged commit eeae5a8 into cloudflare:master May 27, 2024
8 checks passed
@github-actions github-actions bot added this to the v4.34.0 milestone May 27, 2024
@josip-stanic josip-stanic deleted the docs/tunnel-config-ingress-rule branch May 27, 2024 07:57
Copy link
Contributor

This functionality has been released in v4.34.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workflow/skip-changelog-entry Denotes an issue or PR does not require a changelog entry to be added before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create cloudflare_tunnel_config with warp_routing enabled
2 participants