Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-blocking issue for POC: Creating empty blocks of data without providing a value. #2996

Closed
2 tasks done
Shannon-McKenzie opened this issue Dec 8, 2023 · 4 comments
Closed
2 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@Shannon-McKenzie
Copy link

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform version 1.4.6
Provider version 4.19.0

Affected resource(s)

Non-blocking issue. Still not the expected results.

Terraform configuration files

resource "cloudflare_teams_account" "teams" {
  account_id           = cloudflare_account.account.id
  activity_log_enabled = true
  tls_decrypt_enabled  = true

  block_page {
    enabled          = true
    background_color = "#ffffff"
    logo_path        = "***"
    header_text      = "***"
    footer_text      = "***"
    name             = "***"
    mailto_address   = "***"
    mailto_subject   = "***"
  }

  body_scanning {
    inspection_mode = "shallow"
  }

  antivirus {
    enabled_download_phase = true
    enabled_upload_phase   = true
    fail_closed            = false
  }

  fips {
    tls = true
  }

  proxy {
    tcp     = true
    udp     = true
    root_ca = true
  }

  url_browser_isolation_enabled = false

  logging {
    redact_pii = false
    settings_by_rule_type {
      dns {
        log_all    = false
        log_blocks = true
      }
      http {
        log_all    = false
        log_blocks = true
      }
      l4 {
        log_all    = false
        log_blocks = true
      }
    }
  }
}
Example config for the cloudflare_access_identity_provider resource:
resource "cloudflare_access_identity_provider" "okta_clientless" {
  account_id = cloudflare_account.account.id
  name       = "Okta Clientless"
  type       = "okta"
  config {
    client_id     = module.okta_oidc_app_clientless.client_id
    client_secret = module.okta_oidc_app_clientless.client_secret
    okta_account  = "https://${var.okta_org_name}.${var.okta_base_url}"
    api_token = var.okta_service_account_token
  }
  dynamic "scim_config" {
    content {
      enabled                  = true
      user_deprovision         = true
      group_member_deprovision = false
      seat_deprovision         = true
    }
  }
}

Link to debug output

n/a

Panic output

No response

Expected output

Nothing should be created due to no input.

Actual output

From customer:

"I’m not currently providing the ssh_session_log param of our cloudflare_teams_account resource, and from the looks of it the provider is building its value as an empty block on state refresh, which doesn’t match the plan since it’s not possible to provide an empty block (public_key is a required attrib of the block), so that causes a cyclical change on plan/apply.

dataminr issue 1 non-blocking

"Another minor provider cyclical change issue, cloudflare_access_identity_provider,config.api_tokenis always detected as a change, I even tried manually setting the token in the console.
Screenshot is back-to-back applies with ~15 seconds between them, demonstrating the cyclical changes detected, for context in case you have trouble replicating, the token is sourced from an input variable that’s tagged as sensitive and it’s an Okta OAuth IDP."

image

Steps to reproduce

See screenshots attached to actual output.

Additional factoids

No response

References

No response

@Shannon-McKenzie Shannon-McKenzie added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Marking this issue as stale due to 30 days of inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

1 participant