Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Add support for resolver policies #3198

Merged
merged 3 commits into from Apr 3, 2024
Merged

enhancement: Add support for resolver policies #3198

merged 3 commits into from Apr 3, 2024

Conversation

joebb97
Copy link
Contributor

@joebb97 joebb97 commented Mar 19, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024 •
edited

changelog detected ✅

@joebb97 joebb97 force-pushed the jbuiteweg/GFI-65-resolver-policies-terraform branch 4 times, most recently from 13a2a40 to e835e2d Compare March 20, 2024 17:26
@joebb97 joebb97 changed the title GATE-4979: Add support for resolver policies enhancement: Add support for resolver policies Mar 25, 2024
@joebb97 joebb97 marked this pull request as draft March 25, 2024 18:00
@joebb97
Copy link
Contributor Author

joebb97 commented Mar 25, 2024

think i found a bug
panic: interface conversion: interface {} is bool, not *bool

@joebb97
Copy link
Contributor Author

joebb97 commented Mar 26, 2024

This PR is dependent upon a change to cloudflare-go. That PR is here cloudflare/cloudflare-go#1615

@joebb97 joebb97 force-pushed the jbuiteweg/GFI-65-resolver-policies-terraform branch from e835e2d to c1d0239 Compare March 28, 2024 15:06
@joebb97 joebb97 marked this pull request as ready for review March 28, 2024 15:11
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsRule_Basic
--- PASS: TestAccCloudflareTeamsRule_Basic (7.50s)
=== RUN   TestAccCloudflareTeamsRule_NoSettings
--- PASS: TestAccCloudflareTeamsRule_NoSettings (10.30s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	18.921s

@jacobbednarz jacobbednarz merged commit 03b61aa into cloudflare:master Apr 3, 2024
7 of 8 checks passed
@github-actions github-actions bot added this to the v4.29.0 milestone Apr 3, 2024
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
Update CHANGELOG.md for #3198
0a54870
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

This functionality has been released in v4.29.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.29.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joebb97 @jacobbednarz