provider: introduce a muxed client #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
With the announcement of the cloudflare-go/v2[1], we need to introduce a way to use both versions of the SDK in the provider. This moves us to a world where the v1 and v2 of the clients can coexist and still be initialised in a consistent fashion. At a high level, the guidance for modifying resources and datasources is: - If you have an existing resource, use the cloudflare-go V1 SDK which whatever version of the Terraform SDK/framework version you have today. - If you have a new resource, build it using cloudflare-go V2 SDK and the terraform-plugin-framework. While this commit is rather large by LOC, it is the following changes but made across the provider. - Introduce a `muxclient` package. Allows Terraform internals to have a single client instead of trying to swap on the fly potentially causing concurrency issues. - Split `acctest.SharedClient` into `SharedV1Client` and `SharedV2Client` for use in both versions of acceptance tests. - Aliases and namespacing to handle the different package versions. These changes should be internal and not end user facing. [1]: https://blog.cloudflare.com/workers-production-safety
jacobbednarz
force-pushed
the
mux-cloudflare-go-versions
branch
from
d12d35f
to
67b9d7f
Compare
alyssamw
pushed a commit
to alyssamw/terraform-provider-cloudflare
that referenced
this pull request
Apr 24, 2024
|
This functionality has been released in v4.31.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the announcement of the cloudflare-go/v2, we need to introduce a
way to use both versions of the SDK in the provider. This moves us to a
world where the v1 and v2 of the clients can coexist and still be
initialised in a consistent fashion.
At a high level, the guidance for modifying resources and datasources is:
whatever version of the Terraform SDK/framework version you have
today.
the terraform-plugin-framework.
While this commit is rather large by LOC, it is the following changes
but made across the provider.
muxclientpackage. Allows Terraform internals to have asingle client instead of trying to swap on the fly potentially causing
concurrency issues.
acctest.SharedClientintoSharedV1ClientandSharedV2Clientfor use in both versions of acceptance tests.
These changes should be internal and not end user facing.