Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Err check for importing aop resources now checks for three params rather than two #859

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Err check for importing aop resources now checks for three params rather than two #859

merged 1 commit into from
Nov 4, 2020

Conversation

dhaynespls
Copy link
Contributor

  • "I think off by one errors are turing tests to make sure the dev is human" - @wolfmd

Closes #858

@dhaynespls
Err check for importing aop resources now checks for three params rat…
961b789 
…her than two

- "I think off by one errors are turing tests to make sure the dev is human" - @wolfmd

Closes #858
@jacobbednarz jacobbednarz merged commit 4766fe9 into cloudflare:master Nov 4, 2020
@dhaynespls dhaynespls deleted the dhaynes/858-off-by-one branch November 4, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Off by 1 bug in resource_cloudflare_authenticated_origin_pulls_* importing
2 participants
@dhaynespls @jacobbednarz