Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

Links in annotations? #152

Closed
filippog opened this issue Aug 2, 2017 · 5 comments
Closed

Links in annotations? #152

filippog opened this issue Aug 2, 2017 · 5 comments
Assignees

Comments

@filippog
Copy link
Contributor

filippog commented Aug 2, 2017

Hi!
thanks for unsee! I'd like to include clickable links in annotation text (e.g. link to relevant logs, dashboards, etc) is there a way to do that? AFAICS the annotation text now isn't styled in any way.

thanks!

@prymitive
Copy link
Contributor

All annotation with URLs in the value should be converted into links and rendered as button, you can see this on the example screenshot: screenshot
Notice dashboard links there.
If some links are not converted into such then it's a bug, can you share an example that doesn't work?

@filippog
Copy link
Contributor Author

filippog commented Aug 3, 2017

@prymitive nice, thanks! Using an url-only annotation works as expected, I thought e.g. https links would be rendered as clickable items inside annotation text e.g. "Foobar has an alert, see logs at https://...". I'm closing this as I think it is resolved!

@filippog filippog closed this as completed Aug 3, 2017
@prymitive
Copy link
Contributor

Current behavior is mostly driven by how we setup alert annotations at Cloudflare. If you put links as part of a larger text I can add support for that easily. Let's re-open it.

@prymitive
Copy link
Contributor

Raised #156 to add this

@filippog
Copy link
Contributor Author

filippog commented Aug 7, 2017

Sounds good, thanks @prymitive! FTR I was satisfied with the annotation-based solution because the links in question are very long (kibana dashboards)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants