Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Article for Cache API #47

Closed
ashleymichal opened this issue May 3, 2019 · 2 comments
Closed

Add Article for Cache API #47

ashleymichal opened this issue May 3, 2019 · 2 comments
Assignees
Milestone

Comments

@ashleymichal
Copy link
Contributor

ashleymichal commented May 3, 2019

This is already started in #42 . Necessary additions:

Document the API surface (objects, methods, properties implemented). Use https://wiki.cfops.it/display/EW/Runtime+API+Doc+Questions for reference, link to mdn where appropriate.

Important to note:

  • put will throw an error if the request method is not GET
  • match will simply return undefined if the request method is not GET
  • put will also throw an error on a response with status code 206.

This issue is part of #11 and related to #44

@harrishancock
Copy link
Contributor

One last cause of put() throwing is trying to store a response with a Vary: * header. Our cache doesn't actually honor the Vary header AFAIK, though -- we just throw because it's required by the spec.

@ashleymichal
Copy link
Contributor Author

closed by #42

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants