Add missing router methods #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @fkettelhoit - I've merged this into a testing branch and will get back to you if there are any changes needed. I think it's a great addition and appreciate the help! This will likely be out with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly adds sync and async router fns for the missing HTTP methods HEAD, PUT, PATCH, DELETE, OPTIONS, CONNECT and TRACE.
I originally added a
with_status_codesetter toResponsein my fork, but later saw that you have since added a nearly identical method, so I merged the two commits and keptwith_statusas the name from the main branch (though perhapswith_status_codeshould be used to be consistent with the existing getter). Let me know if you would prefer to have a separate PR for thewith_statusreturn value type change.