Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: v3 HTTPS support #3353

Closed
aaronadamsCA opened this issue May 26, 2023 · 8 comments 路 Fixed by #3529
Closed

馃悰 Bug: v3 HTTPS support #3353

aaronadamsCA opened this issue May 26, 2023 · 8 comments 路 Fixed by #3529
Assignees
Labels
bug Something that isn't working

Comments

@aaronadamsCA
Copy link

aaronadamsCA commented May 26, 2023

Describe the solution

In Wrangler v3, --local-protocol=https is currently unsupported during wrangler dev and wrangler pages dev:

https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/src/dev/miniflare.ts#L374-L378

Miniflare 3 does not support HTTPS servers yet, starting an HTTP server instead...

However, Miniflare v3 specifically describes HTTPS support in its documentation:

https://miniflare.dev/get-started/cli#https-server

I can't find any existing issue tracking this missing v3 feature, so I wanted to start one, as it's important for certain use cases.

@aaronadamsCA aaronadamsCA added the enhancement New feature or request label May 26, 2023
@Hexstream
Copy link

Hexstream commented Jun 3, 2023

This is baffling to me, as all my websites have been HTTPS-only for years, and many modern web platform features are HTTPS-only. There is simply no feasible way to develop or test my websites on plain HTTP.

Please fix this urgently!

edit: For now I reverted back to wrangler 2.20.0 with volta install wrangler@2.20.0.

@danielkoek
Copy link

I would also disagree with it being an "[enhancement]" as at the moment it is not working while all the documentation leads to that it is working, including the wrangler documentation, so at least update the docs if anything.

Personally i think this is a must to include since these days you never want anything non https to begin with, for us the problem is that we can't locally sign in now into the FE without having a full https connection

@IgorMinar
Copy link
Contributor

@GregBrimble also mentioned that certain oauth providers require https for a callback so the lack of https support breaks these workflows.

@admah admah added bug Something that isn't working v3 labels Jun 7, 2023
@admah
Copy link
Contributor

admah commented Jun 7, 2023

@aaronadamsCA thanks for submitting this. This is a regression from v2, and something that should be working in v3. Sorry for the delayed response. Our team is taking a look at it now.

@JacobMGEvans JacobMGEvans changed the title 馃殌 Feature Request: v3 HTTPS support 馃悰 Bug: v3 HTTPS support Jun 7, 2023
@admah admah removed the enhancement New feature or request label Jun 7, 2023
@mrbbot
Copy link
Contributor

mrbbot commented Jun 30, 2023

Hey everyone! 馃憢 We've just released a new beta version of Wrangler that includes local support for running HTTPS server. Try it out with npx wrangler@beta dev --local-protocol https. Please let us know if you encounter any issues. 馃檪

@sdarnell
Copy link

Lack of https was preventing me using wrangler 3 for local dev, so thanks for adding it back in. 馃憤
But I'd request that we have an option to override/specify the cert to use. So that I can use a cert that is trusted in my keychain (generated with mkcert fwiw). Having a cert that is trusted by browsers is much less painful than having to acknowledge browser warnings, or regularly add multiple new certs to the right keychains (imagine working on n projects, each with their own self signed cert). A cmd line option, or env var would be fine for me - though I'd prefer a single/pair of cmd line options.

@Hades32
Copy link

Hades32 commented Jul 1, 2023

@sdarnell FYI there is a setting in Chrome to trust localhost always. I found that to be the most pragmatic solution

@Hexstream
Copy link

This is fixed in wrangler 3.1.2, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.