-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Bug: v3 HTTPS support #3353
Comments
This is baffling to me, as all my websites have been HTTPS-only for years, and many modern web platform features are HTTPS-only. There is simply no feasible way to develop or test my websites on plain HTTP. Please fix this urgently! edit: For now I reverted back to |
I would also disagree with it being an "[enhancement]" as at the moment it is not working while all the documentation leads to that it is working, including the wrangler documentation, so at least update the docs if anything. Personally i think this is a must to include since these days you never want anything non https to begin with, for us the problem is that we can't locally sign in now into the FE without having a full https connection |
@GregBrimble also mentioned that certain oauth providers require https for a callback so the lack of https support breaks these workflows. |
@aaronadamsCA thanks for submitting this. This is a regression from v2, and something that should be working in v3. Sorry for the delayed response. Our team is taking a look at it now. |
Hey everyone! 馃憢 We've just released a new |
Lack of https was preventing me using wrangler 3 for local dev, so thanks for adding it back in. 馃憤 |
@sdarnell FYI there is a setting in Chrome to trust localhost always. I found that to be the most pragmatic solution |
This is fixed in wrangler 3.1.2, thanks!! |
Describe the solution
In Wrangler v3,
--local-protocol=https
is currently unsupported duringwrangler dev
andwrangler pages dev
:https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/src/dev/miniflare.ts#L374-L378
However, Miniflare v3 specifically describes HTTPS support in its documentation:
https://miniflare.dev/get-started/cli#https-server
I can't find any existing issue tracking this missing v3 feature, so I wanted to start one, as it's important for certain use cases.
The text was updated successfully, but these errors were encountered: