Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Build failure returns code 0 #335

Closed
ateixeira-pt opened this issue Jul 21, 2019 · 4 comments · Fixed by #432
Closed

Build failure returns code 0 #335

ateixeira-pt opened this issue Jul 21, 2019 · 4 comments · Fixed by #432
Assignees

Comments

@ateixeira-pt
Copy link

wrangler build always returns 0 even when it fails to build

@xtuc xtuc added feature Feature requests and suggestions user report labels Jul 21, 2019
@ateixeira-pt ateixeira-pt changed the title Build failure retuns code 0 Build failure returns code 0 Jul 21, 2019
@ateixeira-pt
Copy link
Author

Sorry forgot to say , I'm testing this on JS

@ateixeira-pt
Copy link
Author

@xtuc this also applies to the publish function and this messes up the CI/CD Pipeline and/or make

@xortive
Copy link
Contributor

xortive commented Jul 22, 2019

Thanks for filing an issue! Could you please provide some more information so we can replicate this issue?

  • what project type is in your wrangler.toml
  • if webpack project and you have a custom webpack config, the contents of your custom webpack config
  • output from wrangler build when it fails

@xortive
Copy link
Contributor

xortive commented Aug 7, 2019

Did some unsuccessful debugging on this issue on latest master branch for wrangler build

  • JS
    • Possible error points
      • Tested - incorrect entry point - returns 0 on build, 1 on publish
        • This doesn’t feel like the issue, wrangler build says "skips build" even if entry point is wrong so it's not putting out a failure message then returning 0 like the issue says
  • Webpack
    • Possible error points
      • Tested - Project config - errors are correctly propagated and return 1
      • Tested - webpack imports - errors are correctly propagated and return 1
      • Tested - webpack stats errors - propagates correctly, returns 1
      • Tested - incorrect entry point - returns 1
      • Tested - broken webpack config - returns 1
      • Tested - wranglerjs exits with error 1 - propagates, wrangler returns 1
  • Rust
    • Possible error points
      • Tested - rust compiler error - returns 1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants