Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Installing on every change wasm-pack / wranglerjs #768

Closed
shyim opened this issue Oct 7, 2019 · 5 comments 路 Fixed by #1003
Closed

Installing on every change wasm-pack / wranglerjs #768

shyim opened this issue Oct 7, 2019 · 5 comments 路 Fixed by #1003
Assignees
Labels
bug Something isn't working
Milestone

Comments

@shyim
Copy link

shyim commented Oct 7, 2019

馃悰 Bug Report

When i run wrangler preview --watch it's installing on every change those packages. Is that normal? It takes lot of time on every change.

Environment

  • operating system: NixOs
  • output of rustc -V: Is not installed
  • output of node -v: v12.5.0
  • output of wrangler -V: wrangler 1.4.0

Steps to reproduce

Empty new Project and then preview it with watch

What did you expect to see?

Faster loading without installing on every change that package

What did you see instead?

Taking time on every change to install that package

@dihmeetree
Copy link

dihmeetree commented Dec 8, 2019

Bump! Would like a way to not have to install wrangler and wasm-pack every time I publish my worker.

@ashleymichal @ashleygwilliams Will this be implemented into the next release? Installing wrangler-js and wasm-pack on every publish is super slow :( (Plus I don't even use wasm in my code)

Maybe just showing a message saying there's an update to one of the packages would be helpful? So we know when we need to update it :)

@EverlastingBugstopper EverlastingBugstopper removed this from the 1.7.0 milestone Dec 16, 2019
@EverlastingBugstopper
Copy link
Contributor

currently we check to see if the latest version of the binary we need is installed on the system. We need to instead check if the latest version is installed in the install directory. this is difficult because our install directory is full of things like wranglerjs-789087 that don't have the version names in the directories.

  1. When we download, we should put the version number in the directory number
  2. When we check if we need an install, we should see if the version number already exists in the download folder (optionally also check the system version)
  3. If there is an updated version we need to install, we should install that and clean up the old one

@ispivey
Copy link
Contributor

ispivey commented May 12, 2020

馃コ This is awesome!

@EverlastingBugstopper EverlastingBugstopper added this to the 1.9.1 milestone May 14, 2020
@protoEvangelion
Copy link

protoEvangelion commented Oct 10, 2020

@EverlastingBugstopper this is still happening for me on every save when running wrangler dev. Is there something I need to install locally?

image

@EverlastingBugstopper
Copy link
Contributor

Sorry, I don't work at Cloudflare anymore. Might be worth opening a new issue for it 馃榿

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants