Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Remove private field as it's now deprecated #782

Closed
wants to merge 1 commit into from
Closed

Remove private field as it's now deprecated #782

wants to merge 1 commit into from

Conversation

stevenfranks
Copy link
Contributor

Fixes #772

@ashleygwilliams ashleygwilliams added this to the 1.5.0 milestone Oct 14, 2019
@ashleygwilliams ashleygwilliams requested review from ashleymichal and ashleygwilliams and removed request for ashleymichal October 21, 2019 16:50
ashleygwilliams
ashleygwilliams approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay and thanks for this! looks great to me! really appreciate it :)

@ashleygwilliams
Copy link
Contributor

hi @stevenfranks !! really sorry about the lack of reply on this PR. we really appreciate this- so please don't let our inaction make you think we don't care. because this PR is a bit old, the merge conflict has gotten pretty hairy. i'll be closing this in favor of a new PR #804, but we're going to cite you in the changelog as in spirit this way truly your contribution. sorry again about the delay on our part- please keep contributing to wrangler! we'll make sure things go smoother on our end the next time <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Remove private from manifest
2 participants
@stevenfranks @ashleygwilliams