This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
allow creation of preview namespace when namespace exists in toml #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/fix-preview-namespace-create
branch
from
858637e
to
cfa2984
Compare
EverlastingBugstopper
changed the title
EverlastingBugstopper
force-pushed
the
avery/fix-preview-namespace-create
branch
from
cfa2984
to
38d56ef
Compare
EverlastingBugstopper
added
status - needs review
and removed
status - work in progress
labels
ashleymichal
suggested changes
Jun 26, 2020
| if is_preview { | ||
| title.push_str("_preview"); | ||
| } | ||
| let msg = format!("Creating namespace with title \"{}\"", title); | ||
| message::working(&msg); | ||
|
|
||
| let client = http::cf_v4_client(user)?; | ||
| let result = create(&client, &target, &title); | ||
| let result = create(&client, &account_id, &title); |
There was a problem hiding this comment.
we should validate the presence of account id in this command; since manifest allows it to be missing or empty, we will get back the cryptic api gateway error.
EverlastingBugstopper
force-pushed
the
avery/fix-preview-namespace-create
branch
from
f2759cb
to
9360438
Compare
EverlastingBugstopper
force-pushed
the
avery/fix-preview-namespace-create
branch
from
9360438
to
6b9b7d7
Compare
ashleymichal
approved these changes
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we introduced KV preview namespaces, we made sure to add nice messages when creating new namespaces so people could easily add the new namespace id to their wrangler.toml in the correct place.
However, we missed a very common case where folks already have a production namespace defined in their wrangler.toml and they want to add a preview namespace. When this is the case, we return an error message intended to only be thrown when running either
wrangler previeworwrangler dev.