This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
endlessly retry connection to devtools websocket #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObsidianMinor
approved these changes
Feb 9, 2021
|
We should probably add a limit to the exponential back-off so users aren't forced to wait an extremely long time if they leave their computer for a bit. |
|
5 minutes?
…On Tue, Feb 9, 2021 at 11:05 AM ObsidianMinor ***@***.***> wrote:
We should probably add a limit to the exponential back-off so users aren't
forced to wait an extremely long time if they leave their computer for a
bit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1752 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWSCDKX2W7JGHRPWTB3V4TS6FTN3ANCNFSM4XBUTBAQ>
.
|
|
Maybe one minute or 30 seconds? It doesn't really hurt to reconnect and we don't want to force users to wait to long (though they can always just kill it and restart wrangler dev). |
added 2 commits
February 9, 2021 15:31
Endlessly retry connection to preview's devtools websocket on `wrangler dev`. With exponential backoff.
ags799
force-pushed
the
asharp/dev-panic
branch
from
86c25c5
to
311f5aa
Compare
done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endlessly retry connection to preview's devtools websocket on
wrangler dev. With exponential backoff.Keeps us from panicking in #1510.
Output looks like
