Fix: Check response status before writing d1 backu (#2296)

...p download output
cloudflare · Nov 28, 2022 · 7da8f0e · 7da8f0e
1 parent c6d9ae9
commit 7da8f0e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/itchy-tigers-jump.md b/.changeset/itchy-tigers-jump.md
@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix: check response status of `d1 backup download` command before writing contents to file
diff --git a/packages/wrangler/src/d1/backups.tsx b/packages/wrangler/src/d1/backups.tsx
@@ -199,6 +199,11 @@ export const DownloadHandler = withConfig<BackupDownloadArgs>(
 
 		logger.log(`🌀 Downloading backup ${backupId} from '${name}'`);
 		const response = await getBackupResponse(accountId, db.uuid, backupId);
+		if (!response.ok) {
+			throw new Error(
+				`Failed to download backup ${backupId} from '${name}' - got ${response.status} from the API`
+			);
+		}
 		logger.log(`🌀 Saving to ${filename}`);
 		// TODO: stream this once we upgrade to Node18 and can use Writable.fromWeb
 		const buffer = await response.arrayBuffer();