Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 BUG: When using init --from-dash, the worker name is missing #1853

Closed
penalosa opened this issue Sep 14, 2022 · 1 comment 路 Fixed by #2127 or #2121
Closed

馃悰 BUG: When using init --from-dash, the worker name is missing #1853

penalosa opened this issue Sep 14, 2022 · 1 comment 路 Fixed by #2127 or #2121
Assignees
@JacobMGEvans
Labels
bug Something that isn't working

Comments

@penalosa
Copy link
Contributor

What version of Wrangler are you using?

2.1.3

What operating system are you using?

Mac

Describe the Bug

Run wrangler init --from-dash <WORKER_NAME>. This is the final prompt (note the cd undefined):
Screenshot 2022-09-14 at 13 47 04
@penalosa penalosa added the bug Something that isn't working label Sep 14, 2022
@JacobMGEvans
Copy link
Contributor

Hmmm it is suppose to default to the parent directory, that is interesting.

JacobMGEvans added a commit that referenced this issue Nov 3, 2022
@JacobMGEvans
Fix: Missing Worker name using --from-dash
caabb36 
Added the fromDashName provided as a fallback when no name is provided in the `wrangler init` command.
Additionally added a checks to the `std.out` to ensure that the name is provided.

resolves #1853
@JacobMGEvans JacobMGEvans mentioned this issue Nov 3, 2022
Merged
JacobMGEvans added a commit that referenced this issue Nov 3, 2022
@JacobMGEvans
Fix: Missing Worker name using --from-dash
2b768af 
Added the fromDashName provided as a fallback when no name is provided in the `wrangler init` command.
Additionally added a checks to the `std.out` to ensure that the name is provided.

resolves #1853
JacobMGEvans added a commit that referenced this issue Nov 3, 2022
@JacobMGEvans
Fix: Missing Worker name using --from-dash
cbc5dd1 
Added the fromDashName provided as a fallback when no name is provided in the `wrangler init` command.
Additionally added a checks to the `std.out` to ensure that the name is provided.

resolves #1853
JacobMGEvans added a commit that referenced this issue Nov 4, 2022
@JacobMGEvans
Fix: Missing Worker name using --from-dash (#2127)
0e561e8 
Added the fromDashName provided as a fallback when no name is provided in the `wrangler init` command.
Additionally added a checks to the `std.out` to ensure that the name is provided.

resolves #1853
@github-actions github-actions bot mentioned this issue Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobMGEvans JacobMGEvans

Labels
bug Something that isn't working
Projects
workers-sdk
Archived in project
Milestone
No milestone
2 participants
@JacobMGEvans @penalosa