Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is printed before login #788

Closed
Electroid opened this issue Apr 13, 2022 · 2 comments · Fixed by #789 or #780
Closed

Error is printed before login #788

Electroid opened this issue Apr 13, 2022 · 2 comments · Fixed by #789 or #780
Labels
polish Small improvements to the experience

Comments

@Electroid
Copy link
Contributor

I ran wrangler publish and the following showed up before the OAuth flow was initiated:

{
  error: 'invalid_request',
  error_verbose: 'The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed',
  error_description: 'The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed\n' +
    '\n' +
    'Make sure that the various parameters are correct, be aware of case sensitivity and trim your parameters. Make sure that the client you are using has exactly whitelisted the redirect_uri you specified.',
  error_hint: 'Make sure that the various parameters are correct, be aware of case sensitivity and trim your parameters. Make sure that the client you are using has exactly whitelisted the redirect_uri you specified.',
  status_code: 400
}
Attempting to login via OAuth...

This doesn't seem like something we need to print to console.

@Electroid Electroid added the polish Small improvements to the experience label Apr 13, 2022
@petebacondarwin
Copy link
Contributor

Hmm... So that is an error from the CF API. Are you able to reproduce it? Perhaps find which API request is triggering the error?

threepointone added a commit that referenced this issue Apr 13, 2022
This removes a couple of logs we had for literally every error in our oauth flow. We throw the error and handle it separately anyway, so this is a safe cleanup.

Fixes #788
@threepointone
Copy link
Contributor

I think this should fix it #789

threepointone added a commit that referenced this issue Apr 13, 2022
This removes a couple of logs we had for literally every error in our oauth flow. We throw the error and handle it separately anyway, so this is a safe cleanup.

Fixes #788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Small improvements to the experience
Projects
None yet
3 participants