Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename "publish" package.json script to "deploy" #1141

Merged
merged 1 commit into from
May 30, 2022

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented May 30, 2022

Closes #1121

@rozenmd rozenmd self-assigned this May 30, 2022
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

🦋 Changeset detected

Latest commit: 9e9f853

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2408476646/npm-package-wrangler-1141

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1141/npm-package-wrangler-1141

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2408476646/npm-package-wrangler-1141 dev path/to/script.js

@threepointone
Copy link
Contributor

@rozenmd
Copy link
Contributor Author

rozenmd commented May 30, 2022

@threepointone: The way I've understood the issue is that publish inside package.json is causing issues with VSCode - doesn't npx pass publish as an argument to wrangler, so that's fine?

@threepointone
Copy link
Contributor

Oh yeah that's right, my bad. I think still need to fix this one tho https://github.com/cloudflare/wrangler2/blob/c433095a9697fbb7f923d4620f03a9fac5f52d97/packages/wrangler/src/index.tsx#L676

@rozenmd
Copy link
Contributor Author

rozenmd commented May 30, 2022

Ah yep true

@threepointone
Copy link
Contributor

Maybe we should add deploy as an alias for the publish command too? We don't have to change it in the docs just yet, but maybe we should work towards it at some point

@rozenmd rozenmd marked this pull request as ready for review May 30, 2022 11:22
@petebacondarwin petebacondarwin merged commit a8c509a into main May 30, 2022
@petebacondarwin petebacondarwin deleted the rename-publish-to-deploy branch May 30, 2022 14:35
@github-actions github-actions bot mentioned this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Consider using different name for publish command in package.json
3 participants