Fix importing npm packages with same name of Node built-ins #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2750ecb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3405110305/npm-package-wrangler-2072You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2072/npm-package-wrangler-2072Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3405110305/npm-package-wrangler-2072 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3405110305/npm-package-cloudflare-pages-shared-2072 |
mrbbot
force-pushed
the
bcoll/fix-npm-node-builtin-import
branch
from
a7ea4a7
to
1731a12
Compare
JacobMGEvans
approved these changes
Oct 28, 2022
Previously, if `node_compat` was disabled, and the user had an npm package with the same name as a Node built-in module installed (e.g. `buffer`), esbuild would always throw instead of resolving it. This PR fixes the issue by relying on esbuild's resolver, and instead rewriting the error message on failure to suggest enabling `node_compat` instead of `platform: "node"`. Closes #2038
mrbbot
force-pushed
the
bcoll/fix-npm-node-builtin-import
branch
from
1731a12
to
2750ecb
Compare
Codecov Report
@@ Coverage Diff @@
## main #2072 +/- ##
==========================================
+ Coverage 73.41% 73.48% +0.07%
==========================================
Files 139 139
Lines 8965 8985 +20
Branches 2327 2334 +7
==========================================
+ Hits 6582 6603 +21
+ Misses 2383 2382 -1
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
node_compatwas disabled, and the user had an npm package with the same name as a Node built-in module installed (e.g.buffer), esbuild would always throw instead of resolving it. This PR fixes the issue by relying on esbuild's resolver, and instead rewriting the error message on failure to suggest enablingnode_compatinstead ofplatform: "node".Closes #2038