-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load .env
/.dev.vars
file based on --env
#2073
Conversation
🦋 Changeset detectedLatest commit: ab8eda3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3419511356/npm-package-wrangler-2073 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2073/npm-package-wrangler-2073 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3419511356/npm-package-wrangler-2073 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3419511356/npm-package-cloudflare-pages-shared-2073 |
Codecov Report
@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
+ Coverage 73.41% 73.51% +0.10%
==========================================
Files 139 139
Lines 8965 8999 +34
Branches 2327 2339 +12
==========================================
+ Hits 6582 6616 +34
Misses 2383 2383
|
Have you considered |
I think that keeping the extension constant would be sensible. |
Interesting that the new Turbopack uses |
Could always add support for both |
Nah, I think I was wrong in my comment. I just assumed people would want to keep the |
71a2260
to
9af3273
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold off merging just a minute until we confirm if global --env
is what we want to do
If `--env <env>` is specified, we'll now check `.env.<env>`/`.dev.vars.<env>` first. If they don't exist, we'll fallback to `.env`/`.dev.vars`. `--env` is now a flag in every command, like `--config`. Closes #1305.
9af3273
to
ab8eda3
Compare
If
--env <env>
is specified, we'll now check.env.<env>
/.dev.vars.<env>
first. If they don't exist, we'll fallback to.env
/.dev.vars
.--env
is now a flag in every command, like--config
.Closes #1305.