fix: --from-dash vars incorrect fields
#2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobMGEvans
requested review from
rozenmd and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: ff0e8f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3381235915/npm-package-wrangler-2124You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2124/npm-package-wrangler-2124Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3381235915/npm-package-wrangler-2124 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3381235915/npm-package-cloudflare-pages-shared-2124 |
Now the `vars` will be computed, example: `[var.binding.name]: var.binding.text` this will resolve the issue that was occurring with generating a TOML with incorrect fields for the `vars` key/value pair. resolves #2048
JacobMGEvans
force-pushed
the
jacobmgevans/from-dash-fix
branch
from
e81209b
to
ff0e8f0
Compare
Codecov Report
@@ Coverage Diff @@
## main #2124 +/- ##
==========================================
- Coverage 73.19% 73.14% -0.06%
==========================================
Files 128 128
Lines 8641 8649 +8
Branches 2266 2267 +1
==========================================
+ Hits 6325 6326 +1
- Misses 2316 2323 +7
|
penalosa
approved these changes
Nov 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computing the name from binding response, now the
varswill be computed, example:[var.binding.name]: var.binding.textthis will resolve the issue that was occurring with generating a TOML with incorrect fields for the
varskey/value pair.resolves #2048