Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version to publish message #2134

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Added version to publish message #2134

merged 2 commits into from
Nov 8, 2022

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Nov 5, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2022

🦋 Changeset detected

Latest commit: 9f00916

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3423417723/npm-package-wrangler-2134

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2134/npm-package-wrangler-2134

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3423417723/npm-package-wrangler-2134 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.developers.workers.dev/runs/3423417723/npm-package-cloudflare-pages-shared-2134

@jspspike jspspike force-pushed the jspspike/publish-version branch 2 times, most recently from 431b4fd to 7dc84c2 Compare November 7, 2022 16:36
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #2134 (9f00916) into main (68f4fa6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
+ Coverage   73.61%   73.65%   +0.03%     
==========================================
  Files         139      140       +1     
  Lines        9032     9041       +9     
  Branches     2348     2348              
==========================================
+ Hits         6649     6659      +10     
+ Misses       2383     2382       -1     
Impacted Files Coverage Δ
.../src/__tests__/helpers/msw/handlers/deployments.ts 100.00% <ø> (ø)
packages/wrangler/src/deployments.ts 100.00% <100.00%> (ø)
packages/wrangler/src/index.tsx 83.40% <100.00%> (-0.40%) ⬇️
packages/wrangler/src/publish/publish.ts 86.82% <100.00%> (+0.14%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably move the command for deployment to the same file as the type, to co-locate things. (non-blocking for this PR)

@jspspike jspspike merged commit b164e2d into main Nov 8, 2022
@jspspike jspspike deleted the jspspike/publish-version branch November 8, 2022 22:22
@github-actions github-actions bot mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants