Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: D1 backup download: check response status #2296

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix: D1 backup download: check response status #2296

merged 1 commit into from
Nov 28, 2022

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Nov 27, 2022

Closes #2293

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2022

🦋 Changeset detected

Latest commit: d615640

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Skye-31 Skye-31 changed the title Fix: Check response status before writing d1 backup download output Fix: D1 backup download: check response status Nov 27, 2022
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3558327034/npm-package-wrangler-2296

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2296/npm-package-wrangler-2296

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3558327034/npm-package-wrangler-2296 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.developers.workers.dev/runs/3558327034/npm-package-cloudflare-pages-shared-2296

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #2296 (d615640) into main (c6d9ae9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
- Coverage   71.61%   71.60%   -0.01%     
==========================================
  Files         151      151              
  Lines        9540     9542       +2     
  Branches     2475     2476       +1     
==========================================
+ Hits         6832     6833       +1     
- Misses       2708     2709       +1     
Impacted Files Coverage Δ
packages/wrangler/src/d1/backups.tsx 26.25% <0.00%> (-0.68%) ⬇️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@Skye-31
Copy link
Contributor Author

Skye-31 commented Nov 27, 2022

I think the test failure was a flake

Copy link
Contributor

@rozenmd rozenmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM 👍

@rozenmd rozenmd merged commit 7da8f0e into cloudflare:main Nov 28, 2022
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
@Skye-31 Skye-31 deleted the d1-backup-download-status branch November 28, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Downloading backup give success but fails unknowingly
2 participants