Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try bump esbuild to 0.15.0 #2592

Merged
merged 2 commits into from
Feb 1, 2023
Merged

fix: try bump esbuild to 0.15.0 #2592

merged 2 commits into from
Feb 1, 2023

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Jan 23, 2023

Making this PR to see if build even passes

resolves #1971

@rozenmd rozenmd self-assigned this Jan 23, 2023
@rozenmd rozenmd requested a review from a team as a code owner January 23, 2023 17:59
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: 7b828b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
wranglerjs-compat-webpack-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/4061834494/npm-package-wrangler-2592

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2592/npm-package-wrangler-2592

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/runs/4061834494/npm-package-wrangler-2592 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/runs/4061834494/npm-package-cloudflare-pages-shared-2592

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #2592 (7b828b6) into main (8d21b2e) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2592      +/-   ##
==========================================
+ Coverage   73.43%   73.47%   +0.04%     
==========================================
  Files         159      159              
  Lines        9858     9858              
  Branches     2631     2631              
==========================================
+ Hits         7239     7243       +4     
+ Misses       2619     2615       -4     
Impacted Files Coverage Δ
packages/wrangler/src/d1/migrations/helpers.ts 35.59% <0.00%> (+1.69%) ⬆️
packages/wrangler/src/git-client.ts 81.25% <0.00%> (+4.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@JacobMGEvans
Copy link
Contributor

Oh interesting. Should manually test it but thats exciting

@rozenmd
Copy link
Contributor Author

rozenmd commented Jan 23, 2023

Yeah don't merge this, I don't trust it

@JacobMGEvans
Copy link
Contributor

Yeah don't merge this, I don't trust it

GitHub: All of CI Passing
Our Team: 🤨

@rozenmd
Copy link
Contributor Author

rozenmd commented Jan 30, 2023

Lol @JacobMGEvans I mean, every other person that has tried to bump this had CI explode, and I do it, and it works? sus

@JacobMGEvans
Copy link
Contributor

Lol @JacobMGEvans I mean, every other person that has tried to bump this had CI explode, and I do it, and it works? sus

@rozenmd I'm working on wrapping up that templates PR it will give us more to run a battery of E2E tests against hopefully giving us more realistic results for things like this 😆😁

@rozenmd
Copy link
Contributor Author

rozenmd commented Jan 31, 2023

Tested wrangler dev and wrangler publish with esbuild 0.15.0, works well - @GregBrimble / @WalshyDev can I assume the fixtures would catch any breaking changes on the pages side?

@GregBrimble
Copy link
Member

You may, yes

@rozenmd rozenmd merged commit dd66618 into main Feb 1, 2023
@rozenmd rozenmd deleted the rozenmd/bump-esbuild branch February 1, 2023 08:24
@github-actions github-actions bot mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants