Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D1] Don't require login when running wrangler d1 migrations list #2657

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Jan 31, 2023

What this PR solves / how to test:

A patch was applied to wrangler d1 migrations apply back in December to not require login - this PR adds a similar patch to wrangler d1 migrations list

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Closes #2515

@rozenmd rozenmd requested a review from a team as a code owner January 31, 2023 16:09
@rozenmd rozenmd self-assigned this Jan 31, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2023

🦋 Changeset detected

Latest commit: f1a346b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/4056021604/npm-package-wrangler-2657

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2657/npm-package-wrangler-2657

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/runs/4056021604/npm-package-wrangler-2657 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/runs/4056021604/npm-package-cloudflare-pages-shared-2657

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #2657 (f1a346b) into main (73807f5) will increase coverage by 0.15%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
+ Coverage   73.31%   73.46%   +0.15%     
==========================================
  Files         159      159              
  Lines        9854     9858       +4     
  Branches     2627     2631       +4     
==========================================
+ Hits         7224     7242      +18     
+ Misses       2630     2616      -14     
Impacted Files Coverage Δ
packages/wrangler/src/d1/migrations/create.tsx 41.93% <0.00%> (+6.45%) ⬆️
packages/wrangler/src/d1/migrations/apply.tsx 34.11% <50.00%> (ø)
packages/wrangler/src/d1/migrations/list.tsx 68.57% <75.00%> (+33.08%) ⬆️
packages/wrangler/src/git-client.ts 81.25% <0.00%> (+4.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything that jumps out at me, looks like a really nice local mode DX improvement

@rozenmd rozenmd merged commit 8d21b2e into main Jan 31, 2023
@rozenmd rozenmd deleted the rozenmd/d1-dont-force-login branch January 31, 2023 19:58
@github-actions github-actions bot mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Most D1 Commands require auth even with --local flag
2 participants