chore: update esbuild #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 028fe95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Update esbuild to 0.14.14. Also had to change `import esbuild from "esbuild";` to `import * as esbuild from "esbuild";` in `dev.tsx`.
threepointone
force-pushed
the
update-esbuild
branch
from
33fc6db
to
028fe95
Compare
JacobMGEvans
approved these changes
Jan 31, 2022
Merged
Merged
There was a problem hiding this comment.
Perhaps we should standardise these kind of imports.
Before this PR we had
import esbuild from "esbuild"; // using a default export, which I guess has now disappeared?
import * as esbuild from "esbuild"; // importing the module as a namespace
import type {BuildResult} from "esbuild"; // just bringing in a type for type checking
import {build} from "esbuild"; // just bringing in the build function directly.
In general, I prefer the last two syntaxes unless the namespace contains dozens of exports that we are using in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update esbuild to 0.14.14. Also had to change
import esbuild from "esbuild";toimport * as esbuild from "esbuild";indev.tsx.