-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler tail tty-awareness and json-respecting #810
Conversation
Closes #493 2 quick fixes: - Check `process.stdout.isTTY` at runtime to determine whether to default to "pretty" or "json" output for tailing. - Only print messages like "Connected to {worker}" if in "pretty" mode (errors still throw strings)
🦋 Changeset detectedLatest commit: 538274e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2174054081/npm-package-wrangler-810 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/810/npm-package-wrangler-810 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2174054081/npm-package-wrangler-810 dev path/to/script.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍞🥖🥐🥯🥨🥪🫓
well, after the tests pass ofc |
aurghhhh they pass on my machine wtf |
CI is not a TTY, maybe that's it? |
Make
wrangler tail
TTY-aware, and stop printing non-JSON in JSON modeCloses #493
2 quick fixes:
process.stdout.isTTY
at runtime to determine whether to default to "pretty" or "json" output for tailing.