Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure getting git branch doesn't fail on Windows #914

Merged

Conversation

sidharthachatterjee
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee commented May 6, 2022

Fixes #900

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2022

🦋 Changeset detected

Latest commit: 0ea5fb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2282969451/npm-package-wrangler-914

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/914/npm-package-wrangler-914

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2282969451/npm-package-wrangler-914 dev path/to/script.js

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any tests for this?

@sidharthachatterjee
Copy link
Contributor Author

@threepointone Unfortunately not at the moment. We'll need to do this "properly" after launch.

@sidharthachatterjee sidharthachatterjee merged commit 9903526 into cloudflare:main May 6, 2022
@sidharthachatterjee sidharthachatterjee deleted the windows-grep branch May 6, 2022 17:49
@github-actions github-actions bot mentioned this pull request May 6, 2022
@CEbbinghaus
Copy link

Love to see it thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: 'grep' is not recognized as an internal or external command
4 participants