fix: add warning to fetch() calls that will change the requested port
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5464941 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2575542454/npm-package-wrangler-992You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/992/npm-package-wrangler-992Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2575542454/npm-package-wrangler-992 dev path/to/script.js |
Electroid
reviewed
May 13, 2022
petebacondarwin
force-pushed
the
fetch-warning
branch
2 times, most recently
from
b058786
to
65ad2fc
Compare
|
If you are interested in testing this locally, you can try adding the following fetch requests to a Worker and running await fetch("http://portquiz.net");
await fetch("https://portquiz.takao-tech.com");
await fetch("http://portquiz.net:8989");
await fetch("https://portquiz.takao-tech.com:8989");
await fetch("http://portquiz.net");
await fetch("https://portquiz.takao-tech.com");
await fetch("http://portquiz.net:8988");
await fetch("https://portquiz.takao-tech.com:8988");
await fetch("http://portquiz.net");
await fetch("https://portquiz.takao-tech.com");
await fetch("http://portquiz.net:8989");
await fetch("https://portquiz.takao-tech.com:8989"); |
In Workers published to the Edge (rather than previews) there is a bug where a custom port on a downstream fetch request is ignored, defaulting to the standard port. For example, `https://my.example.com:668` will actually send the request to `https://my.example.com:443`. This does not happen when using `wrangler dev` (both in remote and local mode), but to ensure that developers are aware of it this change displays a runtime warning in the console when the bug is hit. Closes cloudflare#1320
petebacondarwin
force-pushed
the
fetch-warning
branch
from
65ad2fc
to
5464941
Compare
threepointone
approved these changes
Jun 28, 2022
Merged
|
Yeah good point. I reopened the issue, let's close it only once we ship the fix in the runtime. |
This was referenced Jun 28, 2022
[Workers] Document that only standard ports are supported by fetch()
cloudflare/cloudflare-docs#4299
Closed
threepointone
added a commit
that referenced
this pull request
Jul 19, 2022
In #992, we added a dev-only helper that would warn when using `fetch()` in a manner that wouldn't work as expected (because of a bug we currently have in the runtime). We did this by injecting a file that would override usages of `fetch()`. When using pnp style package managers like yarn, this file can't be resolved correctly. So to fix that, we extract it into the temporary destination directory that we use to build the worker (much like a similar fix we did in #1154) Reported at #1320 (comment)
threepointone
added a commit
that referenced
this pull request
Jul 19, 2022
In #992, we added a dev-only helper that would warn when using `fetch()` in a manner that wouldn't work as expected (because of a bug we currently have in the runtime). We did this by injecting a file that would override usages of `fetch()`. When using pnp style package managers like yarn, this file can't be resolved correctly. So to fix that, we extract it into the temporary destination directory that we use to build the worker (much like a similar fix we did in #1154) Reported at #1320 (comment)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Workers published to the Edge (rather than previews) there is a bug where a custom port on a downstream fetch request is ignored, defaulting to the standard port.
For example,
https://my.example.com:668will actually send the request tohttps://my.example.com:443.This does not happen when using
wrangler dev(both in remote and local mode), but to ensure that developers are aware of it this change displays a runtime warning in the console when the bug is hit.Closes #1320