oAuth token refresh

[rkoster]

This PR uses the oauth2 lib for getting the UAA token.
This comes with the added benefit of support for refresh tokens.

[rkoster]

cc @longnguyen11288

[simonjohansson]

Ive added .travis.yml to master if you want to rebase in that into this branch instead of commiting it here :)

[rkoster]

@simonjohansson have removed the travis related changes from this branch, have cherrypicked the README change onto master.

[simonjohansson]

Coolio!

Ill take a look at this PR.

[simonjohansson]

When doing a godep save it pulls in a dep that is not in Godeps.json

diff --git a/Godeps/Godeps.json b/Godeps/Godeps.json
index 3cf77bf..89b3662 100644
--- a/Godeps/Godeps.json
+++ b/Godeps/Godeps.json
@@ -30,6 +30,11 @@
                        "Rev": "754d38fccfc6e52083355014b6abc8d626445dfd"
                },
                {
+                       "ImportPath": "github.com/smartystreets/assertions",
+                       "Comment": "1.5.0-380-g4727d76",
+                       "Rev": "4727d767ce8a81811c40eedc2a836c85aebb4d09"
+               },
+               {
                        "ImportPath": "github.com/smartystreets/goconvey/convey",
                        "Comment": "1.5.0-386-geb2e83c",
                        "Rev": "eb2e83c1df892d2c9ad5a3c85672da30be585dfd"

[rkoster]

I'm only able to reproduce the above Godeps.json diff when checking out the current master

[simonjohansson]

@rkoster
I might be doing something wrong, but here is how I reproduce it

➜  go-cfclient git:(oauth_token_refresh) git checkout master 
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
➜  go-cfclient git:(master) git branch -d oauth_token_refresh
warning: deleting branch 'oauth_token_refresh' that has been merged to
         'refs/remotes/origin/oauth_token_refresh', but not yet merged to HEAD.
Deleted branch oauth_token_refresh (was da150b3).
➜  go-cfclient git:(master) git pull
Already up-to-date.
➜  go-cfclient git:(master) git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean
➜  go-cfclient git:(master) git log --name-status | cat | head -n 5
commit f292098e5581d2dbcb4e796dd3d7801f29efe8cd
Merge: 3a58fc7 e519aa5
Author: Long Nguyen <long.nguyen11288@gmail.com>
Date:   Wed May 6 08:45:44 2015 -0400

➜  go-cfclient git:(master) git checkout -b oauth_token_refresh origin/oauth_token_refresh
Branch oauth_token_refresh set up to track remote branch oauth_token_refresh from origin.
Switched to a new branch 'oauth_token_refresh'
➜  go-cfclient git:(oauth_token_refresh) git log --name-status | cat | head -n 5                       
commit da150b310d0d02369e73c227380335dd9b86e853
Author: Ruben Koster <rkoster@starkandwayne.com>
Date:   Wed May 6 12:08:19 2015 +0200

    Switch to oauth2 lib for UAA token (comes with refresh token support)
➜  go-cfclient git:(oauth_token_refresh) godep save
➜  go-cfclient git:(oauth_token_refresh) ✗ git diff | cat   
diff --git a/Godeps/Godeps.json b/Godeps/Godeps.json
index 3cf77bf..89b3662 100644
--- a/Godeps/Godeps.json
+++ b/Godeps/Godeps.json
@@ -30,6 +30,11 @@
            "Rev": "754d38fccfc6e52083355014b6abc8d626445dfd"
        },
        {
+           "ImportPath": "github.com/smartystreets/assertions",
+           "Comment": "1.5.0-380-g4727d76",
+           "Rev": "4727d767ce8a81811c40eedc2a836c85aebb4d09"
+       },
+       {
            "ImportPath": "github.com/smartystreets/goconvey/convey",
            "Comment": "1.5.0-386-geb2e83c",
            "Rev": "eb2e83c1df892d2c9ad5a3c85672da30be585dfd"

[rkoster]

After following the above steps there where still no changes on my machine

[simonjohansson]

fakeUAAServer is great!

[simonjohansson]

Maybe better to wait 0s instead of 3s to speed up the tests?

gomega.Eventually(client.GetToken(), "3s").Should(gomega.Equal("bearer foobar3"))
|
v
gomega.Eventually(client.GetToken(), "0s").Should(gomega.Equal("bearer foobar3"))

[simonjohansson]

| After following the above steps there where still no changes on my machine

How weird, probably my machine that have some issues then.

[rkoster]

Are you talking about this time?

[rkoster]

with regard to the expires_in time, the token will be seen as expired before the 3 seconds have elapsed. Since an expiryDelta is taken into account.

[simonjohansson]

Besides my missunderstanding of the test case, and my weird environment on my machine this looks great!

What is the rules in this repo, more than one review to merge?

[rkoster]

As can be seen on travis, the token refresh test only task 0.10s.

[rkoster]

cc @longnguyen11288

[lnguyen]

I think one person reviewing is fine. Nothing to strict. @simonjohansson

[simonjohansson]

@longnguyen11288 ok, coolio.